chore(python): fix erroneous versions detected in detect_versions()#1248
Merged
chore(python): fix erroneous versions detected in detect_versions()#1248
Conversation
parthea
requested review from
SurferJeffAtGoogle,
bcoe and
chingor13
as code owners
google-cla
bot
added
the
cla: yes
This was referenced Oct 20, 2021
parthea
force-pushed
the
fix-erroneous-versions-detected
branch
from
52eaa92 to
7f76b37
Compare
Contributor
Author
|
I tested the post processor in this commit in a PR on python-webrisk and it produced the correct result. |
Contributor
Author
|
I also tested the post processor in this commit in a PR on python-phishingprotection and it produced the correct result. |
chingor13
approved these changes
Oct 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1246 added ability to detect versions recursively when
detect_versions()is called, however we're seeing erroneous versions detected in python-webrisk here.I've updated the code to stop searching subdirectories if versions are found in the parent directory. I've also added a test to confirm the behaviour.
With the code in #1246, the following versions are detected.
With the code in this PR, the following versions are detected